GUVI

[landsito]

Support for TIMED-GUVI L1C intensity datasets.

Description

Spectrograph and imaging sensors handled by inst_id, and resolutions handled by tags of high and low.

Addresses # (issue) -Added platform TIMED and instruments for GUVI L1C datasets. -Methods of load and download included and tested. -cdaweb was improved to consider cases found in GUVI:

• remote directory uses doy only instead of day/month combinations
• cadence of directory format is now for yearly, monthly, and daily (when using doy). -platform was added into documentation -platform was added in init for registration

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

It was tested following pysat guidelines using pytest -vs -flake8 pysatNASA

Test Configuration

• Operating system: [macosx]
• Version number: [Python 3.8]
• locally installed using conda

Checklist:

• [x] Make sure you are merging into the develop (not main) branch
• [ ] My code follows the style guidelines of this project
• [ ] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have been merged and published in downstream modules
• [x] Add a note to CHANGELOG.md, summarizing the changes
• [x] Update zenodo.json file for new code contributors

[jklenzing]

Adding a note to my self. Testing the default pysat.utils.io.load_netcdf as a possible alternative to loading.

data, meta = pysat.utils.io.load_netcdf(fnames, pandas_format=False, epoch_name='TIME_EPOCH_DAY', decode_times=True)

This works for a single file, but for a list of files (required for GUVI), I get

ValueError: Could not find any dimension coordinates to use to order the datasets for concatenation

from xarray. It's possible we can pass through a list of coords or other options to fix this in the xarray interface, but would require some updates on the pysat side. https://docs.xarray.dev/en/stable/generated/xarray.open_mfdataset.html

[jklenzing]

Hmm. It looks like there's still a whitespace issue in the style check. See feedback here: https://github.com/pysat/pysatNASA/actions/runs/3678408300/jobs/6221630783

It looks like there have been some issues with the comment system for modifying code. @landsito, it might be easier if you update the last two lines on your machine and push.

Bringing @rstoneback and @JonathonMSmith into the conversation. The code is working locally, but needs some updates to metadata. Should we fix that in this branch or merge and work on that in develop. Could be easier for the team to help update things from a single branch. Any preferences on how to proceed?

[rstoneback]

If you think the final steps would be easier in develop that is ok with me.

[landsito]

Thanks @jklenzing and @rstoneback. I made the change that seems to be needed but not sure if this is actually helpful. hopefully it will work now. Let me know how else I can help.

[jklenzing]

Thanks @landsito. I caught another typo in my updates and sorted that out. The code is running fine locally, but failing here due to a new numpy release. Let's plan to chat in the new year at one of the upcoming developer meetings. I'll pull together some more notes and ping you offline.

[aburrell]

It looks good! 😀 🚀