BUG: GOLD

[jklenzing]

Description

Partially Addresses #139

Updates GOLD NMAX to use sortby to guarantee the index is monotonic increasing. Scans from two separate instruments are combined into one xarray object. The long term goal is to separate these into separate instruments, but this is waiting on constellation updates in pysat.

Note: This does not guarantee that the index will be unique. Between 2018 day 278 and 2023 day 64, approximately 0.3% of files have a non-unique index. 51% of the files have a non-monotonic index.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

import pysat
gold = pysat.Instrument('ses14', 'gold', tag='nmax')
gold.load(2020, 1)

In develop, this will fail due to non-monotonic increasing index.

Test Configuration

• Operating system: Mac Monterrey
• Version number: python 3.10.8

Checklist:

• [x] Make sure you are merging into the develop (not main) branch
• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules
• [x] Add a note to CHANGELOG.md, summarizing the changes
• [x] Update zenodo.json file for new code contributors