pysatCDF has known issues with numpy>= 1.24 (see https://github.com/pysat/pysatCDF/issues/46). Since this is an optional install, the test behavior here is altered so that a package-wide version cap for numpy is not required.
Updates GA tests to only use pysatCDF install for NEP29 tests (currently set to numpy 1.21)
Includes logic in test_instruments so that additional load tests with cdflib are only run when pysatCDF is correctly installed. (The default behavior of the load routines is to use pysatCDF if possible, then fall back to cdflib, unless specified by the use_cdflib kwarg)
Removes the additional tests for xarray instruments, which are only supported by cdflib.
NOTE: this is required before #155 can be tested.
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Running Lines 1-41 of test_instruments.py to inspect whether instruments['cdf'] is correctly generate (ie, ACE and TIMED/SEE instrument not included since these are xarray).
Running pytest with pysatCDF installed and not installed to verify that skipif tests are working correctly.
Test Configuration
Operating system: Monterrey
Version number: python 3.10.8
Checklist:
[x] Make sure you are merging into the develop (not main) branch
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Add a note to CHANGELOG.md, summarizing the changes
[x] Update zenodo.json file for new code contributors
Description
Addresses #142
pysatCDF has known issues with numpy>= 1.24 (see https://github.com/pysat/pysatCDF/issues/46). Since this is an optional install, the test behavior here is altered so that a package-wide version cap for numpy is not required.
pysatCDFinstall for NEP29 tests (currently set to numpy 1.21)cdflibare only run whenpysatCDFis correctly installed. (The default behavior of the load routines is to usepysatCDFif possible, then fall back tocdflib, unless specified by theuse_cdflibkwarg)cdflib.NOTE: this is required before #155 can be tested.
Type of change
How Has This Been Tested?
Running Lines 1-41 of test_instruments.py to inspect whether instruments['cdf'] is correctly generate (ie, ACE and TIMED/SEE instrument not included since these are xarray).
Running pytest with pysatCDF installed and not installed to verify that skipif tests are working correctly.
Test Configuration
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changes