pysat / pysatNASA

pysat support for NASA Instruments

BSD 3-Clause "New" or "Revised" License

21 stars 7 forks source link

ENH: gps instruments and deprecate jpl_gps #159

Closed jklenzing closed 1 year ago

jklenzing commented 1 year ago

Description

Addresses #93 and #121 (partial)

Adds the rest of the TEC products. roti is moved to be part of igs_gps. Includes style consistency for init function.

Deprecates jpl_gps.

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

via pytest

Test Configuration

Operating system: Mac Monterey
Version number: python 3.10.8

Checklist:

[x] Make sure you are merging into the develop (not main) branch
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Add a note to CHANGELOG.md, summarizing the changes
[x] Update zenodo.json file for new code contributors

jklenzing commented 1 year ago

Re-running the failed windows/3.10 tests. May be related to a bug in the core pysat.

JonathonMSmith commented 1 year ago

this is passing locally on my windows machine