Added new tags into SES14-GOLD

[landsito]

Description

Added tags tlimb, tdisk and o2den into SES14-GOLD platform

Addresses # (issue) Tlimb, Tdisk and o2den tags into SES14-GOLD platform. It uses recent multiday loading capabilities with option of merging coords.

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Simple multiday script run.

pysat.utils.registry.register(['pysatNASA.instruments.ses14_gold'])
gold = pysat.Instrument(platform='ses14', name='gold', tag='o2den')

d0 = datetime(2019,9,5)
dn = datetime(2019,9,7)

gold.download(d0, dn)
gold.load(date=d0, end_date=dn)

Test Configuration

• Operating system: macOS Catalina
• Version number: Python 3.8.16

Checklist:

• [x] Make sure you are merging into the develop (not main) branch
• [ ] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules
• [x] Add a note to CHANGELOG.md, summarizing the changes
• [x] Update zenodo.json file for new code contributors

[jklenzing]

Hmm, I should have flagged my other pull here.

There's a few points in the code that will still fail in the Github Actions tests. This is because we need the develop branch of pysat for the current implementation, and there were some updates in pysatNASA functions that didn't quite get merged. The fixes in the branch inst\gold_pr (which is downstream of this branch) fixes these issues. We can either

• merge that into @landsito's branch using https://github.com/landsito/pysatNASA/pull/1 and then finish the review here, or
• merge this branch in and open a bug fix pull here to clean that up.

I wound up making the downstream branch since the changes were beyond the scope of the current "suggest code" capabilities of github.

@landsito, let me know how you want to proceed. My main concern is that I don't want to break anything on your end for projects you're currently working on. I think that the next pysatNASA release will follow on from the pysat 3.1.0 release (hopefully in the next month) since that includes fixes that streamline things here.

Thanks @JonathonMSmith and @aburrell for the reviews!

[landsito]

Hi @jklenzing, thanks for the message. Let's go for the second options if it is easier. First option also works for me so either way. Let me know, thanks

[jklenzing]

OK. my other branch captures most of the comments here. I'll go ahead and start the process rolling.

• [ ] merge in comments not captured in jeff's branch
• [ ] approve and merge
• [ ] new pull

[jklenzing]

Bugs fixed downstream.