pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 7 forks source link

TST: RC test fixes #168

Closed jklenzing closed 1 year ago

jklenzing commented 1 year ago

Description

Updates several bugs in the RC testing due to new behaviour at Github Actions.

pysatCDF tests removed for the time being (documented in #167).

Adds a yml to manage readthedocs

Type of change

How Has This Been Tested?

At github actions. Include manual run of pysat_rc workflow for this branch to test with https://github.com/pysat/pysat/pull/1116

Checklist:

jklenzing commented 1 year ago

python 3.10 on windows expected to fail. Updates to pysat in the RC have fixed these. See: https://github.com/pysat/pysatNASA/actions/runs/4812031229

jklenzing commented 1 year ago

The readthedocs buld was failing, potentially caused by a new release of urllib3. See https://readthedocs.org/projects/pysatnasa/builds/20451047/

Added a readthedocs.yml according to the instructions, which appears to fix the issue. Note the default install was using python 3.7.

jklenzing commented 1 year ago

@JonathonMSmith is --no-cache-dir what we want here? Or do we need a different option?

JonathonMSmith commented 1 year ago

@jklenzing If we use --no-cache-dir I think pip will still favor wheels. If we want to avoid downloading wheels, then we need the --no-binary option as well. This is the --no-binary deprecation issue.

jklenzing commented 1 year ago

@jklenzing If we use --no-cache-dir I think pip will still favor wheels. If we want to avoid downloading wheels, then we need the --no-binary option as well. This is the --no-binary deprecation issue.

OK. looking through the code, the no-binary option is required to get pysatCDF to build correctly. However, since there are other problems with that and we've shut off the tests for now, we can just build the older numpy as usual.

jklenzing commented 1 year ago

@JonathonMSmith, can you take a look at the final config? This should be good to go, but I'd like another set of eyes on this.