pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 7 forks source link

BUG: SSUSI bug and function deprecation #170

Closed aburrell closed 1 year ago

aburrell commented 1 year ago

Description

Fixes a bug identified when running several years of SSUSI data that revealed the dimensions sometimes change. Also deprecated a function introduced to pysat from this package, partially addressing issue #169.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Added a unit test and also loaded a year of data (2010, one day at a time) for F16.

Test Configuration

Checklist:

aburrell commented 1 year ago

Failing due to issues addressed in #129, I believe.

jklenzing commented 1 year ago

Since SSUSI data has not yet been released, do we need to deprecate the code? The next release here will be after pysat 3.1.0 and have that as a minimum req.

aburrell commented 1 year ago

Waiting on https://github.com/pysat/pysat/pull/1116 and https://github.com/pysat/pysat/pull/1123 before tests will pass.

jklenzing commented 1 year ago

Re-running with pysat 3.1.0, we get

 ValueError: coordinate 'Epoch' not present in all datasets.

for the timed saber data. This appears in the other pull too, so something probably changed with expand_dims. Or possibly there's another update I haven't seen yet

jklenzing commented 1 year ago

Found the bug, it was in issue with TIMED SABER revealed by the new exapnd_dims code. Out of scope here, working on a solution. Wrote up a summary in #174

jklenzing commented 1 year ago

Merging in the recent changes from develop should fix the errors