Closed aburrell closed 1 year ago
Failing due to issues addressed in #129, I believe.
Since SSUSI data has not yet been released, do we need to deprecate the code? The next release here will be after pysat 3.1.0 and have that as a minimum req.
Waiting on https://github.com/pysat/pysat/pull/1116 and https://github.com/pysat/pysat/pull/1123 before tests will pass.
Re-running with pysat 3.1.0, we get
ValueError: coordinate 'Epoch' not present in all datasets.
for the timed saber data. This appears in the other pull too, so something probably changed with expand_dims. Or possibly there's another update I haven't seen yet
Found the bug, it was in issue with TIMED SABER revealed by the new exapnd_dims
code. Out of scope here, working on a solution. Wrote up a summary in #174
Merging in the recent changes from develop
should fix the errors
Description
Fixes a bug identified when running several years of SSUSI data that revealed the dimensions sometimes change. Also deprecated a function introduced to pysat from this package, partially addressing issue #169.
Type of change
Please delete options that are not relevant.
Breaking change (fix or feature that would cause existing functionalityto not work as expected)How Has This Been Tested?
Added a unit test and also loaded a year of data (2010, one day at a time) for F16.
Test Configuration
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changes