pysat / pysatNASA

pysat support for NASA Instruments

BSD 3-Clause "New" or "Revised" License

21 stars 7 forks source link

MAINT/BUG: cdflib 1.0+ syntax #183

Closed jklenzing closed 1 year ago

jklenzing commented 1 year ago

Description

Addresses #179

Updates syntax for cdflib 1.0+. Maintains backwards compatibility for Operational environment.

Github Actions workflow updated so that operational env uses cdflib<1.0 (to be compatible with numpy 1.19)

Minor bug fixes at cdflib (>=1.0.4) solve the issues documented at #179.

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Via pytest with cdflib 1.0.4

Test Configuration

Operating system: Monterrey
Version number: Python 3.10.9
pysat 3.1.0, cdflib 1.0.4

Checklist:

[x] Make sure you are merging into the develop (not main) branch
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] Add a note to CHANGELOG.md, summarizing the changes
[x] Update zenodo.json file for new code contributors