Header meta

[JonathonMSmith]

Description

Addresses #176

When loading a dataset into a pandas dataframe header level metadata was not being attached.

Type of change

Please delete options that are not relevant.

• Bug fix

How Has This Been Tested?

• Local pytest
• Manual check

Test Configuration

• Operating system: [MacOS 13.4]
• Version number: [Python 3.9]
• conda environment

Checklist:

• [x] Make sure you are merging into the develop (not main) branch
• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have been merged and published in downstream modules
• [x] Add a note to CHANGELOG.md, summarizing the changes
• [ ] Update zenodo.json file for new code contributors

[jklenzing]

Looks like the ACE xarray instruments are failing on the pull side, probably due to recent changes. The new ace load routine doesn't have a 'use_cdflib' option, since it always uses this.

[JonathonMSmith]

yeah, also it looks like test_load_cdflib is always skipped. I don't see it ever passing, only getting skipped.

[jklenzing]

yeah, also it looks like test_load_cdflib is always skipped. I don't see it ever passing, only getting skipped.

It's only run when pysatCDF is installed, which is never installed because it's broken

I just realized this is definitely a bug. You could merge in the changes from develop and add **kwargs to the ace load function to let other stuff pass through unused

[JonathonMSmith]

I'll give it a shot

[jklenzing]

Long term I think we want to add the header meta test to pysat, but we need that to be the default there first. Probably should add a TODO statement here linking to that issue.