pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 6 forks source link

BUG/ENH: ACE Meta data and unused time dimensions #188

Closed jklenzing closed 1 year ago

jklenzing commented 1 year ago

Description

Addresses #186

Creates a custom load routine for ACE data products. Data is loaded as xarray, then extra dimensions (labels for string time values) are dropped.

Type of change

How Has This Been Tested?

Using the workflow in #186 and checking the metadata

Test Configuration

Checklist:

jklenzing commented 1 year ago

warnings down from 4505 to 1277

jklenzing commented 1 year ago

Still a few to fix, all in the mag_l2 key 1hr instrument.

import pysat
mag = pysat.Instrument('ace', 'mag_l2', tag='key', inst_id='1hr', use_header=True)
mag.load(2020, 1)

All three variables throw the 'meta dropped for fill' warning when run with the clean routine, but are fine info clean_level is set to None. Inspecting the metadata, it looks like everything is transferred correctly.

EDIT: I would be ok leaving this as an issue for 0.1.0