search

pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 7 forks source link

MAINT: usage of `decode_times` kwarg #189

Closed jklenzing closed 1 year ago

jklenzing commented 1 year ago

Is your feature request related to a problem? Please describe. When loading netCDF files from xarray, the decode_times kwarg is nominally set to False. This means that numbers with "timelike" units (seconds, hours, etc) will remain as numbers rather than be converted to datetime objects. pysat has deprecated this default to keep in line with xarray.

Describe the solution you'd like Best practices say we should specify this here where appropriate to maintain behavior.

Describe alternatives you've considered Set the default to False at pysat.

Additional context n/a

jklenzing commented 1 year ago

linked branch is downstream of #188