pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 6 forks source link

Maven mgs #200

Closed t-esman closed 1 year ago

t-esman commented 1 year ago

Description

Addresses #(issue)

Adds MAVEN pysat compatibility (No specific issue number).

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

    import pysat
    from pysat.utils import registry
    registry.register_by_module(pysatNASA.instruments)

    mag = pysat.Instrument(platform='maven', name='mag')
    mag.download(dt.datetime(2020, 1, 1), dt.datetime(2020, 1, 31))
    mag.load(2020, 1, use_header = True)

Test Configuration:

Checklist:

If this is a release PR, replace the first item of the above checklist with the release checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

jklenzing commented 1 year ago

It looks like a new dataset for ISS FPMU was uploaded, which is breaking the tests here. Out of scope for this PR.

jklenzing commented 1 year ago

It looks like a new dataset for ISS FPMU was uploaded, which is breaking the tests here. Out of scope for this PR.

Added Issue #201 to cover the ISS FPMU bug. This is an upstream issue, so ignore it for the time being in the tests.

jklenzing commented 1 year ago

Pinging @JonathonMSmith to see if the new cdasws routines could help streamline the new instruments as well.

jklenzing commented 1 year ago

Hmm. The insitu data is now having issues with loading. Verified this via loading locally. Getting an error via xarray:

ValueError: broadcasting cannot handle duplicate dimensions on a variable: ['time', 'compno_3', 'compno_3']
jklenzing commented 1 year ago

Hmm. The insitu data is now having issues with loading. Verified this via loading locally. Getting an error via xarray:

ValueError: broadcasting cannot handle duplicate dimensions on a variable: ['time', 'compno_3', 'compno_3']

The issue is with the general cleaning routine. fix incoming...