Closed jklenzing closed 1 year ago
Still needs:
The acknowledgement string is more complicated than expected. Using standard copy paste for now, documented potential paths forward in #207.
Note for testing:
import pysat
import pysatNASA
reach = pysat.Instrument(inst_module=pysatNASA.instruments.reach_dosimeter, inst_id='101')
reach.acknowledgements
yields
'Please load a file for full acknowledgments.'
Assuming you have downloaded files, running
reach.load(date=reach.files.files.index[0])
reach.acknowledgements
will then yield the full acknowledgement string.
Ok, the data loads well, but the global file attributes in MetaHeader have problems. A benign example that I would let pass is reach.meta.header.Notes
is nan
. A malignant example is Temperature_Sensitivity_43-65_deg
, whose string format is not appropriate for an attribute name and so is not accessible. I think this can be fixed by replacing the -
with a _
in the load function.
Note: you can access the object using getattr(reach.meta.header, 'Temperature_Sensitivity_43-65_deg')
, but not reach.meta.header.Temperature_Sensitivity_43-65_deg
. This raises SyntaxError: invalid decimal literal
.
Description
Type of change
How Has This Been Tested?
Test Configuration:
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release