pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 6 forks source link

ENH: unzip support for download #209

Closed jklenzing closed 1 year ago

jklenzing commented 1 year ago

Description

Addresses #103

Adds support to unzip files after download for zip files. Users can now specify a 'zip_method' as part of the download tags, which will send the zipped file to a temporary directory and extract it to the archival location.

Current version supports 'zip' only, but could be expanded for other file types later.

Type of change

How Has This Been Tested?

Tested with pysatModels at https://github.com/pysat/pysatModels/pull/132

Test Configuration:

Checklist:

If this is a release PR, replace the first item of the above checklist with the release checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

jklenzing commented 1 year ago

Needs a test for the new bits of code. The only routine that uses this is in pysatModels. Potentially we can create a test object with a few zipped files hosted here.

jklenzing commented 1 year ago

Removed the gz support for now since the TIMED datasets have other problems. Can be expanded in the future.

Moving forward without tests for the time being to support pysatModels.

jklenzing commented 1 year ago

Documented need for tests and possible solutions as #213.

jklenzing commented 1 year ago

Coverage change consistent with new lines of code.