MAINT: cnofs vefi magnetometer data

[jklenzing]

Description

C/NOFS VEFI dc_b data has an updated dataset (v6) uploaded to SPDF as of 7 Nov 2023. This does not use the old error flag, but uses the standard fill value demarked in metadata. Since 'B_flag' is no longer present, unit tests will fail unless this is fixed.

Updates to use the standard cleaning routine

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

import datetime as dt
import pysat

# Get latest data
vefi = pysat.Instrument('cnofs', 'vefi', tag='dc_b')
vefi.download(dt.datetime(2009, 1, 1))

# Load with clean routine
vefi.load(2009, 1)
print(vefi.meta['B_north'].fill)

# Load without cleaning
vefi = pysat.Instrument('cnofs', 'vefi', tag='dc_b', clean_level='none')
vefi.load(2009, 1)
print(vefi.meta['B_north'].fill)

Verify that for the clean routine the fill value is NaN, and for the non-clean load the fill value is -1e+31

Test Configuration:

• Operating system: Ventura
• Version number: Python 3.10.9

Checklist:

• [x] Make sure you are merging into the develop (not main) branch
• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules
• [x] Add a note to CHANGELOG.md, summarizing the changes
• [x] Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the release checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

[jklenzing]

What happens if people have local data that is older than v6?

It still loads, and is cleaned for fill values. The flag indicates where data is interpolated in the previous solution.

So for version 5, it will load but not remove these points.

[aburrell]

Could you have the local clean method wrap the standard clean and apply the old code if 'B_flag' is present? That way it'd work for any version.

[jklenzing]

Could you have the local clean method wrap the standard clean and apply the old code if 'B_flag' is present? That way it'd work for any version.

Yes, but it would be untested (other than locally)