BUG: de2 vefi load

[jklenzing]

Description

Addresses #211

Deprecates the combined vefimagb data product under de2_vefi, replaces with new de2_vefimagb instrument module.

This product contains multiple time indices, the new instrument allows users to choose which one to load. For the deprecated version, only the mag data is kept to tentatively solve the issue raised in #211.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

How Has This Been Tested?

    import datetime as dt
    import pysat

    # Set electric field instrument
    vefi = pysat.Instrument(platform='de2', name='vefimagb', tag='e')
    vefi.download(dt.datetime(1983, 1, 1))

    # Set magnetic field instrument
    mag = pysat.Instrument(platform='de2', name='vefimagb', tag='b')

    # Both instruments can be loaded from the same download
    vefi.load(1983, 1)
    mag.load(1983, 1)

Test Configuration:

• Operating system: Ventura
• Version number: Python 3.10.9

Checklist:

• [x] Make sure you are merging into the develop (not main) branch
• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules
• [x] Add a note to CHANGELOG.md, summarizing the changes
• [x] Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the release checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

[aburrell]

It looks like there needs to be some data cleaning implemented, since this is supposedly 'clean'.

[jklenzing]

It looks like there needs to be some data cleaning implemented, since this is supposedly 'clean'.

or maybe a warning? Cleaning is only based on fill vals.

[aburrell]

Looking at the data some of those are clearly fill values, they just aren't recognized by the clean method.

[jklenzing]

Looking at the data some of those are clearly fill values, they just aren't recognized by the clean method.

The fill vals are improperly set. Adding a warning. There are set to 0 in the meta, clearly 1e7.