pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 7 forks source link

MAINT: NEP29 Apr 2024, zenodo updates #227

Closed jklenzing closed 2 months ago

jklenzing commented 5 months ago

Description

Type of change

How Has This Been Tested?

via GitHub Actions main.yml

Checklist:

If this is a release PR, replace the first item of the above checklist with the release checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

jklenzing commented 5 months ago

Note that test failures caused in part by https://github.com/pysat/pysat/issues/1196

jklenzing commented 5 months ago

Adding the "new_test" flag to dmsp_ssusi fixes the memory issue. The remaining issue is in pysat. Could comment out the clean_warn flags with an issue to fix for the next release.

jklenzing commented 5 months ago

Pinging @aburrell for comments on the path forward

aburrell commented 5 months ago

Adding the "new_test" flag to dmsp_ssusi fixes the memory issue. The remaining issue is in pysat. Could comment out the clean_warn flags with an issue to fix for the next release.

This seems like the best path forward.

jklenzing commented 5 months ago

So.... tests for python 3.10 and 3.12 work on ubuntu, and tests for 3.11 work on windows, and everything else is failing with some sort of netCDF4 / HDF error. This particular combination is failing consistently.

aburrell commented 3 months ago

Can we "allow fail" for the Ops tests?

jklenzing commented 3 months ago

NOTE: test_w_pad now fails for maven_sep, presumably due to new xarray releases. Documented in #222.

aburrell commented 3 months ago

Looks like you may need to update coveralls to use Coveralls Actions or follow the steps I took at OCBPy.

aburrell commented 3 months ago

Since the coveralls coverage-reporter is failing regardless of what I do, I have asked support for their help.

jklenzing commented 2 months ago

Added #232 to cover the open issue. Also tweaked the minimum numpy version for the June 2024 update.