pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 6 forks source link

SSUSI bug #231

Closed aburrell closed 4 months ago

aburrell commented 5 months ago

Description

Addresses an issue found when loading subsequent days of DMSP SSUSI SDR-Disk data, which caused a memory failure. Fixed by adding a custom concat_data method. This shares many lines of code with TIMED GUVI, so the comment elements were moved to pysatNASA.instruments.methods.jhuapl.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

import datetime as dt
import pysat

ssusi = pysat.Instrument('dmsp', 'ssusi', 'sdr-disk', 'f18')
stime = dt.datetime(2010, 4, 14)

ssusi.load(date=stime)  # Will be fine

stime += dt.timedelta(days=1)
ssusi.load(date=stime)  # Will fail and potentially crash your computer without fix

Test Configuration:

Checklist:

If this is a release PR, replace the first item of the above checklist with the release checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

jklenzing commented 5 months ago

Could you rebase into the #227 pull? That is the most functional branch and may fix the issues with test failure here