pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 6 forks source link

Empty return without remote files #238

Closed aburrell closed 3 months ago

aburrell commented 3 months ago

Description

Addresses the presence of an error being raised when no remote files are found, instead of an empty list.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

import datetime as dt
import pysat
import pysatNASA

stime = dt.datetime(2024, 1, 1)
etime = dt.datetime(2024, 2, 1)
out_list = pysatNASA.instruments.methods.cdaweb.cdas_list_remote_files(tag='sdr-disk', inst_id='f18', start=stime, stop=etime, supported_tags=pysatNASA.instruments.dmsp_ssusi.download_tags, series_out=False)
out_series = pysatNASA.instruments.methods.cdaweb.cdas_list_remote_files(tag='sdr-disk', inst_id='f18', start=stime, stop=etime, supported_tags=pysatNASA.instruments.dmsp_ssusi.download_tags, series_out=True)

Note, there is data for this instrument and time, but CDAWeb cannot find it 😿

Test Configuration:

Checklist:

If this is a release PR, replace the first item of the above checklist with the release checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

jklenzing commented 3 months ago

Note, there is data for this instrument and time, but CDAWeb cannot find it 😿

The cdasws software sadly does not support ssusi, only ssj and ssm. Just double-checked with the latest version. As test code, this should do what is needed for this bug.