search

pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 6 forks source link

STY: cdaweb methods streamline #72

Open jklenzing opened 3 years ago

jklenzing commented 3 years ago

Some of the target parsing in the cdaweb methods for recognizing file names could be improved.

Alternatively, better incorporation of the official API may replace these routines entirely.

jklenzing commented 1 year ago

It looks like using the get_original_filenames function in cdasws will handle this in a much more streamlined way. It won't eliminate the problem, as not all datasets are supported here.

jklenzing commented 1 year ago

cdasws was incorporated in #145, solving this for most datasets.

To close, I think that the following lines need to be simplified. https://github.com/pysat/pysatNASA/blob/b0003c1405f2bdb06187643ddf1533c52fc06bb7/pysatNASA/instruments/methods/cdaweb.py#L769-L788

Probably need to incorporate a directory structure as part of supported_tags so that the layers loop can be removed.

jklenzing commented 1 year ago

Work on after merge of #200