search

pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 6 forks source link

BUG: fix omni imf steadiness for new pysat #75

Closed jklenzing closed 3 years ago

jklenzing commented 3 years ago

Addresses #74.

test with develop branch of pysat

pytest -vs pysatNASA/tests/test_omni_hro.py::TestOMNICustom
aburrell commented 3 years ago

Ok, I overlooked something. The steadiness shouldn't work for a tag of ''. The test should be modified to update the Instrument tag to a sensible value.

jklenzing commented 3 years ago

But then we can't run the test on the pysat_testing instrument, since pysat checks to see if the tag is appropriate. It might be worth noting in #34 that this test needs to be overhauled as well.