Omni quickfix meta

[aburrell]

Description

Inelegantly addresses #95 by altering the meta data in the load routine.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

import pysat
omni = pysat.Instrument('omni', 'hro', '1min')
omni.load(2020, 102)
omni.meta['SYM_D']

Produces:

FIELDNAM                                              SYM/D index
SCALEMIN                                                    -1000
SCALEMAX                                                     1000
VAR_TYPE                                                     data
FORMAT                                                         I5
DEPEND_0                                                    Epoch
LABLAXIS                                              SYM/D index
DISPLAY_TYPE                                          time_series
units                                                          nT
long_name                                                   SYM_D
notes                                                         NaN
desc            SYM/D - 1-minute SYM/D index,from WDC Kyoto (1...
value_min                                                   -1000
value_max                                                    1000
fill                                                        99999
children                                                     None
Name: SYM_D, dtype: object

Test Configuration

• Operating system: OS X Mojave
• Version number: Python 3.9
• Any details about your local setup that are relevant: develop branch of pysat

Checklist:

• [x] Make sure you are merging into the develop (not main) branch
• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules
• [x] Add a note to CHANGELOG.md, summarizing the changes
• [x] Update zenodo.json file for new code contributors

[jklenzing]

This looks reasonable to me, but I am still getting 28 instances of pysat/pysat/_meta.py:404: UserWarning: Array elements are not allowed in meta. Dropping input : Var_Type when running pytest, both in this branch and in develop. I'm not sure if this is a separate issue, or something that is buried deeper in the code. I don't see this when trying to load OMNI data in the terminal.

[aburrell]

This won't remove that warning, because array elements are initially being loaded into meta by the default load routine. To fix that warning someone (not me) needs to go into the load routine and clean it up.

[jklenzing]

Found the source of the warnings, which is from other instruments and now documented at #99 and unrelated to the issues this branch addresses.

I've opened an alternate branch which solves this particular issue in the cdf load routines (affecting all instruments), but that may require deeper testing. Some of the C/NOFS instruments have lists in the var_atts as well. @aburrell, I'm happy merging this in for now once the GA tests finish if you need a working branch ASAP.