pysat / pysatNASA

pysat support for NASA Instruments
BSD 3-Clause "New" or "Revised" License
21 stars 6 forks source link

BUG: limit coveralls version #98

Closed jklenzing closed 3 years ago

jklenzing commented 3 years ago

Description

Coveralls 3.3 is failing on github actions across platforms. Limiting install to see if something in the new version is at fault.

https://github.com/TheKevJames/coveralls-python/releases

Type of change

How Has This Been Tested?

If this successfully runs on Github Actions, it works.

Test Configuration

Github Actions

Checklist:

jklenzing commented 3 years ago

Note: same error seen in the Github Actions logs documented here: https://github.com/TheKevJames/coveralls-python/issues/333

jklenzing commented 3 years ago

This solves the problem for the time being. Looking through the logs, the broken version use coveralls 3.3 and coverage 6.1.1. The last working version uses coveralls 3.2 and coverage 5.5 (as does this branch). Looking through the issues at both packages, the problem seems to be on the coverage side, but this is not something we currently control in test_requirements. We could add it and put the limit there in theory.

jklenzing commented 3 years ago

Leaving changelog blank until we decide which package gets the limit.

jklenzing commented 3 years ago

Pinging all the core developers for thoughts via review.