pysat / pysatSpaceWeather

pysat support for space weather indices and data sets
BSD 3-Clause "New" or "Revised" License
7 stars 5 forks source link

Bug fixes and Documentation examples #85

Closed aburrell closed 2 years ago

aburrell commented 2 years ago

Description

Adds tutorials for the F10.7, ACE, and Kp/Ap methods. Also fixes a bug when loading historic F10.7 data with old and new formats together. Fixes a bug in the ACE routine where the biases were adjusted for a limited number of years. Partially addresses #2.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Ran tutorials.

Test Configuration

Checklist:

If this is a release PR, replace the first item of the above checklist with the release checklist on the pysat wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

aburrell commented 2 years ago

@jklenzing any idea what's up with the test failures? Everything local passes, so it's one of the CI tests.

jklenzing commented 2 years ago

@jklenzing any idea what's up with the test failures? Everything local passes, so it's one of the CI tests.

This is a bug with pysat 3.0.2. Documented at pysat/pysat#1039. The fix should be easy to implement, but we should probably test against the release candidate when that is up.

aburrell commented 2 years ago

Requesting review since the failures are not related to the code or documentation.