pysat / pysatSpaceWeather

pysat support for space weather indices and data sets
BSD 3-Clause "New" or "Revised" License
9 stars 5 forks source link

BUG: download error for days past end of database #87

Closed aburrell closed 1 year ago

aburrell commented 2 years ago

Description

The historic F10.7 data base will raise a JSON error if you ask for a time when they don't have data.

To Reproduce this bug:

Steps to reproduce the behavior:

import pysat
from pysatSpaceWeather.instruments import sw_f107

f107_hist = pysat.Instrument(inst_module=sw_f107, tag='historic')
f107_hist.download(start=f107_hist.lasp_stime, stop=f107_hist.today(), freq='MS')

Test configuration

Possible solutions

1) Consider this a feature, since it's clear nothing has been downloaded 2) And an end date attribute to the Instrument (similar to the lasp_stime attribute) 3) Something else?

jklenzing commented 2 years ago

just pushed a new branch with a possible solution: f107_patch

downstream of #85