pysb / pysb

Python framework for Systems Biology modeling
BSD 2-Clause "Simplified" License
166 stars 71 forks source link

is_equivalent_to does not include the defined compartment #77

Closed spgarbet closed 10 years ago

spgarbet commented 11 years ago

The is_equivalent_to doesn't include defined compartment as part of the comparison.

This patch will not work properly until the as_complex_pattern patch is put in place (Issue #76). I needed this modification to get SmolDyn working with PySB. https://github.com/spgarbet/pysb/commit/5abf63bd7a9cc567bef6cb8fea8b4ee5cf3f847e

spgarbet commented 11 years ago

I merged the current head of pysb/pysb master in and this broke again. I have a new patch with test case for you.

https://github.com/LoLab-VU/pysb/commit/6edcf38dbd999bfa9fb7dd5f2ebf39144981fdcf

jmuhlich commented 10 years ago

Fixed in #87