search

pyscience-projects / pyevtk

PyEVTK (Python Export VTK) exports data to binary VTK files for visualization/analysis with packages like Paraview, VisIt, and Mayavi.
Other
63 stars 15 forks source link

Enhancement: Field data export #17

Closed MuellerSeb closed 4 years ago

MuellerSeb commented 4 years ago

This PR adresses #15. In addition I made some corrections in the code:

renefritze commented 4 years ago

Thank you for the contribution @MuellerSeb !

I'm having a little trouble discovering the functional changes in between the formatting ones. Can you help me with that?

I've also update the CI setup in #18 just now, if you rebase on master now, travis can work again.

MuellerSeb commented 4 years ago

Thank you for the contribution @MuellerSeb !

I'm having a little trouble discovering the functional changes in between the formatting ones. Can you help me with that?

I've also update the CI setup in #18 just now, if you rebase on master now, travis can work again.

I did a review, pointing out the essential changes.

I also rebased and travis succeeded.

renefritze commented 4 years ago

Great! Thanks. Those changes look good to me.

While I do not mind the style changes personally, lets see if @somada141 or @xylar have strong opinions.

MuellerSeb commented 4 years ago

Cool. Is @somada141 still active on GitHub?

renefritze commented 4 years ago

I like the updated formatting. It might be hard to merge changes from Paulo Herrera's version but I don't think we expect much from there.

Indeed. There hasn't been anything in over a year. We can always just run black on the remote too before a hypothetical merge though.

Cool. Is @somada141 still active on GitHub?

Let's wait till monday with the merge in either way.

renefritze commented 4 years ago

Thank you again @MuellerSeb, I'll try to prepare a new release today.

MuellerSeb commented 4 years ago

@renefritze : maybe we could address #19 first, before releasing a new version.