pyscience-projects / pyevtk

PyEVTK (Python Export VTK) exports data to binary VTK files for visualization/analysis with packages like Paraview, VisIt, and Mayavi.
Other
63 stars 15 forks source link

added keyword for name of dataset in a collection #31

Closed StRuoff closed 3 years ago

StRuoff commented 3 years ago

Fix #30

codecov-commenter commented 3 years ago

Codecov Report

Merging #31 (3f6a513) into master (5cb3370) will decrease coverage by 1.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   71.58%   70.50%   -1.08%     
==========================================
  Files           6        6              
  Lines         834      834              
==========================================
- Hits          597      588       -9     
- Misses        237      246       +9     
Impacted Files Coverage Δ
pyevtk/vtk.py 85.50% <100.00%> (ø)
pyevtk/_version.py 41.57% <0.00%> (-3.23%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cb3370...3f6a513. Read the comment docs.

renefritze commented 3 years ago

Looks good. I see no reason not to merge this. Thank you for your contribution! Releasing v1.3 right away.

Edit: v1.4.0 actually

StRuoff commented 3 years ago

Edit: v1.4.0 actually

(When) Will the package be available for conda? In the PyPI repo I can already see it.

renefritze commented 3 years ago

It may take a couple of hours to a day or so until the conda-forge bot updates the feedstock via PR. You can watch this repo for updates.

StRuoff commented 3 years ago

I just checked the new versions from PyPI and conda, but they both seem to lack the new parts of the code. Did something go wrong there? If i download the zip/tar file for the tag, the changes are not in them.

renefritze commented 3 years ago

I just checked the new versions from PyPI and conda, but they both seem to lack the new parts of the code. Did something go wrong there? If i download the zip/tar file for the tag, the changes are not in them.

My fault. Tagged the wrong commit. Sorry for that. Machinery is running for v1.4.1 now