search

pyscripter / SynEdit

SynEdit is a syntax highlighting edit control, not based on the Windows common controls.
26 stars 11 forks source link

Fixed an issue where text ranges could not be selected with the mouse. #94

Closed m-matsubara closed 4 months ago

m-matsubara commented 4 months ago

SB_ENDSCROLL is not sent when the lower word of wParam is SB_THUMBPOSITION in the WM_HSCROLL, WM_VSCROLL message. For this reason, when scrolling was performed using SB_THUMBPOSITION (scroll function of some pointing devices), it was incorrectly determined that the scrolling was continuing, and a bug was fixed in which the text range could not be selected using the mouse. (Just to be safe, FIsScrolling is set to True while scrolling is being processed.)

pyscripter commented 4 months ago

Thank you. The changes look harmless, but could you please open an issue describing the issue? It is nice to have a record of what exactly is fixed. Please provide detailed instructions for reproducing the error.

In my limited testing SB_ENDSCROLL is always called.

@MShark67 Could you please review this PR?

m-matsubara commented 4 months ago

My apologies. I had thought that there were some terminals where it would occur and others where it would not, but it turns out that it seems to be an inherent problem with the middleware I was using that assists scrolling. It seems that SB_ENDSCROLL is the correct way to be called after SB_THUMBPOSITION as well, so I am withdrawing the pull request.