search

pyscripter / python4delphi

Free components that wrap up Python into Delphi and Lazarus (FPC)
MIT License
923 stars 315 forks source link

Inconsistencies in project files #288

Closed jr2804 closed 3 years ago

jr2804 commented 3 years ago

1) The project files for Python.dproj, PythonVcl.dproj and PythonFmx.dproj do not contain all source files and rely on Delphi to find them in the directory next to them and should be included. Due to this, the non-included files are compiled next to their source path (in the folder Source), which is really bad style. It is common practice to have all .dcu files located at one single output directory (without .pas files), which can be added as a library project. The following structures are suggested:

imageimageimage

Note 1: Please also have a look at the revised required packages (e.g., Vcl is not required for Python.bpl). Note 2: I checked this issue only for Delphi 10.4 project files, don't know if it's valid also for other projects.

2) In consequence, the setting "Unit output directory" should be set to " .\$(Platform)\$(Config)" as default for all projects.

3) All units Source\fmx\WrapFmx*.pas try in include {$I Definition.Inc}, but it should be {$I ..\Definition.Inc} (as in Source\vcl\Vcl.Python*.pas).

pyscripter commented 3 years ago

Could you please submit a PR for this issue?

jr2804 commented 3 years ago

Done, see #290