search

pyscripter / python4delphi

Free components that wrap up Python into Delphi and Lazarus (FPC)
MIT License
895 stars 307 forks source link

changes to fix Lazarus and FreePascal compilation issues. #413

Closed norayr closed 1 year ago

norayr commented 1 year ago

current git release wasn't compiling under Lazarus/fpc, so here is the fix.

norayr commented 1 year ago

2023-03-13-lazarus-python4delphi 2023-03-13-lazarus-python4delphi_

norayr commented 1 year ago

now it builds, i guess you did not test it with fpc for a long time, and it did not build without the fixes in this commit.

i hope i did everything right. feel free to edit my code.

pyscripter commented 1 year ago

I see the issue. I just suggested some simplifications.

norayr commented 1 year ago

I see the issue. I just suggested some simplifications.

Yes, please suggest. Or you can apply the pull request and then apply your own improvements.

norayr commented 1 year ago

I see the issue. I just suggested some simplifications.

maybe I did not notice, where did you suggest some changes?

norayr commented 1 year ago

i guess you were doing code review and forgot to press 'submit review' button.

pyscripter commented 1 year ago

i guess you were doing code review and forgot to press 'submit review' button.

Indeed.

norayr commented 1 year ago

hey, sorry for pinging you again.

but would you like to merge it? or did you solve it yourself already?

pyscripter commented 1 year ago

Sorry for the delay. Very busy right now. I will deal with PR in a couple of weeks.