pysersic / pysersic

Bayesian fitting of Sersic profiles to galaxy images accelerated with jax
MIT License
23 stars 1 forks source link

Banding in rendered images using HybridRenderer #56

Open tbmiller-astro opened 4 months ago

tbmiller-astro commented 4 months ago

Both Imad and I have noticed banding in the rendered images when using the Fourier space based renderers. This is almost certainly an artifact of the rendering or convolution that is done in Fourier space as that is known to produce these periodic artifacts. The good news is it doesn't appear to affect the fit at all, the recovered properties appear reasonable.

It is unclear exactly what conditions trigger this. It is seen in both ground and space based data.

Would be good to track down and fix any potential numerical artifacts that are causing this.

prappleizer commented 4 months ago

Logging a few examples of the effect here, will begin looking at whether there are any particular identifiable features in the data that seem to correlate. We have a sample of ~7000 galaxies to go through to put together a more "robust" sample of where this kind of thing is happening.

Screenshot 2024-06-06 at 12 50 06 PM Screenshot 2024-06-06 at 12 50 46 PM
tbmiller-astro commented 4 months ago

Thanks! That's interesting I've never seen it off center actually. The few times I have witnessed it radiates from the galaxies center only. That is strange.

prappleizer commented 4 months ago

Yeah, So the center of galaxy case is more common; I have those as well. i had jotted these down for being EXTRA weird for having two.

The following are more common, which tend to be a single banding that emanates from the center. Already I'm noticing that it seems to happen with very edge on galaxies more often? And also perhaps tracks where a sharp feature exists on top of a elongated structure. The secondary ones might be due to additional features, or perhaps is some harmonic of the central one.

Screenshot 2024-06-06 at 1 05 44 PM Screenshot 2024-06-06 at 1 04 45 PM Screenshot 2024-06-06 at 1 07 45 PM