search

pyskell / slouchy

Slouchy uses your webcam to check if you're slouching and alert you if you are.
GNU General Public License v3.0
800 stars 47 forks source link

added Opencv3 support #17

Closed fultonms closed 8 years ago

fultonms commented 8 years ago

This fixes the forward compatibility issues.

The cv2.cv submodule was removed in opencv3.0, and some constants were changed. I have edited the code to check opencv version, and use the correct constant for OpenCV 3.0 and OpenCV 2.

This adds a dependency with the package imutils, which can be installed with pip install imutils. However, this is not an intense change, and MUST be made for slouchy to work with OpenCV 3.0 and on.

pyskell commented 8 years ago

Thank you for your changes. I'm definitely open to moving to OpenCV3 and will merge your changes tomorrow after I test and verify them :smile:

landscape-bot commented 8 years ago

Code Health Code quality remained the same when pulling 41f1bff on emu4hire:opencv3VersionCompatability into d94ee00 on pyskell:master.

fultonms commented 8 years ago

Yeah, no problem. I really wanted to run this script to try it out, and didn't feel like downgrading OpenCV.

Out of curiosity, are there any areas of development that you are interested in contribution for?

pyskell commented 8 years ago

Mostly better slouch detection (doesn't work too well if you vary the distance you sit from your computer). And other types of bad posture (such as leaning your head to the side).

The augoust-changes branch is addressing this a bit and will be merged back into master soon. On Oct 28, 2015 5:53 PM, "Michael Fulton" notifications@github.com wrote:

Yeah, no problem. I really wanted to run this script to try it out, and didn't feel like downgrading OpenCV.

Out of curiosity, are there any areas of development that you are interested in contribution for?

— Reply to this email directly or view it on GitHub https://github.com/pyskell/slouchy/pull/17#issuecomment-152006176.

pyskell commented 8 years ago

But I'm always looking for further improvements. On Oct 28, 2015 5:57 PM, "Anthony Lusardi" ajlusardi@gmail.com wrote:

Mostly better slouch detection (doesn't work too well if you vary the distance you sit from your computer). And other types of bad posture (such as leaning your head to the side).

The augoust-changes branch is addressing this a bit and will be merged back into master soon. On Oct 28, 2015 5:53 PM, "Michael Fulton" notifications@github.com wrote:

Yeah, no problem. I really wanted to run this script to try it out, and didn't feel like downgrading OpenCV.

Out of curiosity, are there any areas of development that you are interested in contribution for?

— Reply to this email directly or view it on GitHub https://github.com/pyskell/slouchy/pull/17#issuecomment-152006176.