search

pyskell / slouchy

Slouchy uses your webcam to check if you're slouching and alert you if you are.
GNU General Public License v3.0
797 stars 47 forks source link

Upgrade to PyQt5 #23

Open nicluo opened 6 years ago

nicluo commented 6 years ago

Hi, I was trying to run this repo but it seems PyQt4 is no longer supported by the Qt company (I got Qt5 installed by default using the install steps). Link to PyQt about page.

I've upgraded the bindings to use PyQt5 imports, one of the bigger changes is switching from old-style signals to new-style signals. The commits are available on my fork and I can make a merge request if you want to.

https://github.com/nicluo/slouchy/commit/aa83facd3da47a6c1b75fa5448e156c3b79f0b59

pyskell commented 6 years ago

Awesome!

I'd be happy to merge this, just might require some updates to the README as well (as far as the Requirements and Dependencies sections). If you can update for the platforms you know about then it would be most appreciated. If not I'll make sure to get to it.