pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.7k stars 539 forks source link

OpenBSD and FreeBSD? #1136

Closed standenboy closed 1 year ago

standenboy commented 1 year ago

So i've recently started to use openbsd on my laptop, and i would have assumed that a shell script would port over to openbsd well, but maybe i'm mistaken

i try to run the script with ani-cli death note and it then returns with checking dependencies and then the program stops and i'm dropped back into my shell

i'm assuming this means there is a section of code that needs to be re-writen to support the BSD's however i'm not knowledgeable enough to know which section the issue is coming from

if i've missed a setting somewhere or an option i'm sorry for the inconvenience

if its of any help i'm running openbsd 7.3 i'm using the latest version of ani-cli

if any more info is needed just ask and ill provide everything i can

71zenith commented 1 year ago

Can u send the output of sh -x $(which ani-cli) death note

standenboy commented 1 year ago
Derisis13 commented 1 year ago

It's cut again, isn't it

standenboy commented 1 year ago

It's cut again, isn't it

cut is used multiple times, could you elaborate on what you mean by this

port19x commented 1 year ago

cut is a core utility, typically provided by the gnu coreutils. We leverage it a lot, but it has some inconsistencies across the plattforms

standenboy commented 1 year ago

Yes of course, do with have any clue as to which cut command is causing the issue?

pirate486743186 commented 1 year ago

bsd is not linux. bsd and gnu utilities are slightly different. Even if you fix this you'll likely have more problems.

Apparently you can install gnu utils on bsd, they will be prefixed with some variation of g/g-/gnu.

standenboy commented 1 year ago

I am aware of the difference between the two, however I didn't know the gnu utils were available, I'll have to try them out and see if I can get it to work

pirate486743186 commented 1 year ago

They could solve this with something similar to this.

case "$(uname -a)" in
    *Darwin*) player_function="${ANI_CLI_PLAYER:-iina}" ;;           # mac OS
    *ndroid*) player_function="${ANI_CLI_PLAYER:-android_mpv}" ;;    # Android OS (termux)
    *steamdeck*) player_function="${ANI_CLI_PLAYER:-flatpak_mpv}" ;; # steamdeck OS
    *MINGW*) player_function="${ANI_CLI_PLAYER:-mpv.exe}" ;;         # Windows OS
    *ish*) player_function="${ANI_CLI_PLAYER:-iSH}" ;;               # iOS (iSH)
    *) player_function="${ANI_CLI_PLAYER:-mpv}" ;;                   # Linux OS
esac
justchokingaround commented 1 year ago

this just looks like a duplicate of issue #1141 pr #1144 fixes it

port19x commented 1 year ago

Assuming it's fixed by #1144. Closing