pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.63k stars 533 forks source link

refactor: split long lines (and some minor stuff) #1152

Closed Derisis13 closed 1 year ago

Derisis13 commented 1 year ago

Refactor: split long lines (and some minor stuff)

Type of change

Description

Long lines are a pain, and while I was at it I made some small changes

Checklist

Additional Testcases

Derisis13 commented 1 year ago

shfmt is (mostly) a good idea, (even though it won't let me split the long android vlc command, should I reduce that line on a roundabout way?) but I don't like that it's lumped together with shellcheck. Even version bump has its own check!

Derisis13 commented 1 year ago

I also suggest adding the -p argument to the shfmt check

Derisis13 commented 1 year ago

Original idea of splitting long lines came from @medanisjbara please credit him whoever ends up merging this

CoolnsX commented 1 year ago

On termux side, since spliting is good idea, what if it doesn't launch app, that's the only concern