pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.63k stars 533 forks source link

refactor: use awk as hex2ascii converter #1158

Closed Veroniclover closed 1 year ago

Veroniclover commented 1 year ago

Pull Request Template

Type of change

Description

ramble here

Checklist

Additional Testcases

port19x commented 1 year ago

I'm hesitant, as we do not currently depend on awk

port19x commented 1 year ago

Yeah, no new dependencies

CoolnsX commented 1 year ago

If we gonna rely on external application for hex2ascii we would go with xxd rather than awk, as it's literally a few words xxd -r -p, xxd comes with vim so it's available in nearly every distro, but since we are not in new dependencies by using our brain as much as possible to tackle the problem with logic.