pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.63k stars 533 forks source link

wrong video load #1173

Closed woolw closed 1 year ago

woolw commented 1 year ago

Metadata (please complete the following information) Version: 4.5.0 OS: Arch Linux x86_64 Kernel: 6.4.2-arch1-1 Shell: bash Anime: full metal alchemist brotherhood

Describe the bug when selecting to play the second episode of fmab, it starts playing a camrip version of suzume no tojimari instead

Steps To Reproduce

  1. run ani-cli
  2. input fmab in the search
  3. select episode 2

Expected behavior should play second episode of fmab

Screenshots (if applicable; you can just drag the image onto github) image

port19x commented 1 year ago

Tested both with and without dub. Can't reproduce

woolw commented 1 year ago

ani-cli_bug.txt

foxTr0t1178 commented 1 year ago

I've been experiencing a similar bug, I had searched for hidamari sketch episode 1 a while ago and then searched for other anime, but now everything I search for just brings me the first episode of hidamari sketch

foxTr0t1178 commented 1 year ago

To clarify, I've had not trouble retrieving the names and episodes of other anime I search for, it's just that when I try to select an episode the intended anime doesn't play, just Hidamari Sketch and only the first episode

woolw commented 1 year ago

for me it only seems to have replaced the second episode of fmab.... every other anime seems to work fine

port19x commented 1 year ago

ani-cli_bug.txt

Nothing out of the ordinary to be seen. Strange

woolw commented 1 year ago

works after deleting cache

Here is the output after deleting the cache and history. ani-cli_working.txt

foxTr0t1178 commented 1 year ago

I'm still facing this issue

foxTr0t1178 commented 1 year ago

How would I delete the cache?

works after deleting cache

Here is the output after deleting the cache and history. ani-cli_working.txt

foxTr0t1178 commented 1 year ago

![Uploading 2023-07-11T171017-0500.png…]()

woolw commented 1 year ago

rm -rf ~/.cache/ani-cli/ at least on linux... no idea about other os

woolw commented 1 year ago

@port19x anything suspicious when comparing the two files?

port19x commented 1 year ago

Haven't checked yet, will do in the afternoon

Derisis13 commented 1 year ago

I have experienced this once while developing the latest allanime fix, it was cache for me as well. The cache can get "corrupted" if you kill ani-cli during the retereival of episode links. Solution for users: clear cache by rm -rf ${XDG_CACHE_HOME:~/.cache}/ani-cli/ or cange quality (at least one should work). Solution to get rid of the bug: clear cache in a sigint trap (IIRC we had a trap function in v2 and v1 and maybe in v3)

port19x commented 1 year ago

I'm sceptical of the way we handle cache right now either way. I don't see a point of a persistent cache over a per-run mktemp -d

Derisis13 commented 1 year ago

I'll read up thoroughly on XDG home directories in the near future and see if we're using it as intended, and see what's the best choice

port19x commented 1 year ago

1178 is also related to cache :skull: