pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.63k stars 533 forks source link

Hyperlinks not opening in VLC (iOS) #1177

Closed MellowKyler closed 1 year ago

MellowKyler commented 1 year ago

Metadata Version: 4.5.0 OS: iOS 16.5.1(c) Shell: iSH

Describe the bug The hyperlink generated does not open in VLC as expected.

Steps To Reproduce

  1. Run ani-cli flcl (or any other anime)
  2. Choose 2 (fooly-cooly)
  3. Choose episode 1
  4. Attempt to click hyperlink

Expected behavior Hyperlink should open in VLC

Video

https://youtube.com/shorts/WZp0ZhO94BA In the video I first demonstrate that other hyperlinks work as intended, but the VLC hyperlink does not.

Update This may not be an issue with the link. When using the --vlc flag, an error is returned: Program "vlc" not found. Please install it. However, I do have VLC installed on my phone.

amonull commented 1 year ago

i just had the same issue as described here and the workaround i managed to do to get videos playing was to:

  1. run ani-cli with ani-cli -d which would download the selected episodes to your phone
  2. using the Files app on your phone navigate to where it is downloaded (if you haven't used cd it should be under ISH/root/)
  3. click on the *.mp4 video to play it should start playing and when clicking the "share" button you can play it on VLC if you want

This isn't ideal as videos do take up a lot of space but this was the only workaround i could find.

I also don't think ISH would be able to access VLC since it is downloaded throught the app store and looking into apple store guidlines it may violate some rules such as the not reading or writing outside the designated area under 2.5.2 which ISH just managed to appeal. This workaround isn't ideal but should work for the time being.

Lockl00p commented 1 year ago

i just had the same issue as described here and the workaround i managed to do to get videos playing was to:

  1. run ani-cli with ani-cli -d which would download the selected episodes to your phone
  2. using the Files app on your phone navigate to where it is downloaded (if you haven't used cd it should be under ISH/root/)
  3. click on the *.mp4 video to play it should start playing and when clicking the "share" button you can play it on VLC if you want

This isn't ideal as videos do take up a lot of space but this was the only workaround i could find.

I also don't think ISH would be able to access VLC since it is downloaded throught the app store and looking into apple store guidlines it may violate some rules such as the not reading or writing outside the designated area under 2.5.2 which ISH just managed to appeal. This workaround isn't ideal but should work for the time being.

iSH is actually able to load the episode into VLC. The issue is, VLC doesn’t support M3U8 files and thus, if iSH tries to open VLC with an M3u8 instead of a MP4 link, it won’t work.

Lockl00p commented 1 year ago

I created a pull request with a fix.