pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.63k stars 533 forks source link

fix: ani-cli cache_dir via mktemp (#1178, #1173) #1182

Closed port19x closed 1 year ago

port19x commented 1 year ago

Pull Request Template

Type of change

Description

Our use of cache_dir didn't actually resemble cache in the traditional sense. Cache would refer to semi-persistent storage that is reused between application runs. In our use, we overwrote it on every run, making it working memory. As such, it belongs in ram.

Ideally we can just concatenate right away.

This should fix #1178 and #1173, tho concatenation would be a more direct fix.

Checklist

Additional Testcases

port19x commented 1 year ago

This should be independently tested on mac os. Not sure how their mktemp behaves