search

pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.9k stars 541 forks source link

Packaging #1203

Closed port19x closed 4 months ago

port19x commented 1 year ago

time to make a new issue for this

Package mainlining

Existing packages outside the distros main repos. If you have the connections, please lobby for inclusion.

Important missing packages

Unimportant missing packages

Package Metadata

Name: ani-cli Description: A cli tool to browse and play anime License: GPLv3 URL: https://github.com/pystardust/ani-cli Dependencies

Here are a all known package recipes:

old issue - repology

nicodebo commented 1 year ago

Hello, I made one for Guix that's working fine so far. (but still has some problems about tput missing command). I'm fairly new to guix and still learning so I won't contribute soon but will probably do it once I'm more knowledgeable. If someone wants to do it, feel free to take this recipe.

(define-module (ani-cli)
  #:use-module (guix licenses)
  #:use-module (guix packages)
  #:use-module (guix git-download)
  #:use-module (gnu packages video)
  #:use-module (gnu packages curl)
  #:use-module (gnu packages terminals)
  #:use-module (guix build-system copy))

(define-public ani-cli
  (let ((commit "c7e6838647b57411d791bd250417eb0925d74cca")
        (revision "0"))
    (package
      (name "ani-cli")
      (version (git-version "master" revision commit))
      (source (origin
                (method git-fetch)
                (uri (git-reference
                      (url "https://github.com/pystardust/ani-cli")
                      (commit commit)))
                (file-name (git-file-name name version))
                (sha256
                 (base32
                  "1ni9pzjb5qh87iz7c8252bx79qadr1qx6jnkqvvjcqrchh7q473a"))))
      (build-system copy-build-system)
      ;; TODO: why does (inputs) does not work. I have to put the dependencies as propagated-inputs.
      ;; TODO: tput command not found
      (propagated-inputs
    (list yt-dlp curl fzf))
      (arguments
       `(#:install-plan
         '(("ani-cli" "bin/")
           ("ani-cli.1" "share/man/man1/"))))
      (home-page "https://github.com/pystardust/ani-cli")
      (synopsis "A cli to browse and watch anime.")
      (description "A cli to browse and watch anime (alone AND with friends). This tool scrapes the site allanime.")
      (license gpl3))))
port19x commented 1 year ago

Missing tput is actually a posix violation of ani-cli that is currently unfixed. It also affects alpine linux. Your recipe seems correct at first glance. tput command not found doesn't impair the functionality of the package, so you may already submit it to their repo

nicodebo commented 1 year ago

thanks for tput info. I'll submit a patch and let you know once it's done.

Rucadi commented 6 months ago

I have created a PR on the nixpkgs repo: https://github.com/NixOS/nixpkgs/pull/302094

which allows to add the dependencies (Any of the supported players or cast / sync)

Example of it right now:

nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withSync nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withCast nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withSyncCast

and supports all the players with: nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withMpv nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withVlc nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withIina

and supports:

nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withMpvAndSync nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withMpvAndCast nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withMpvAndSyncCast

nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withVlcAndSync nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withVlcAndCast nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withVlcAndSyncCast

nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withIinaAndSync nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withIinaAndCast nix run github:rucadi/nixpkgs/ani-cli#ani-cli.withIinaAndSyncCast

It makes it easier to test and use.

justchokingaround commented 6 months ago

good

port19x commented 4 months ago

Packaging is good enough nowadays