feat: thumbnails support

[justchokingaround]

Pull Request Template

Type of change

• [ ] Bug fix
• [x] Feature
• [ ] Documentation update

Description

requires fzf version 0.44.0: https://github.com/junegunn/fzf/releases/tag/0.44.0

didn't document in help, man or readme bc lazy

Checklist

• [x] any anime playing

• [x] bumped version

• [x] next, prev and replay work
• [x] -c history and continue work
• [x] -d downloads work
• [x] -s syncplay works
• [x] -q quality works
• [x] -v vlc works
• [x] -e select episode works
• [x] -S select index works
• [x] -r range selection works
• [x] --dub and regular (sub) mode both work

• [x] all providers return links (not necessarily on a single anime, use debug mode to confirm)

• [ ] -h help info is up to date
• [ ] Readme is up to date
• [ ] Man page is up to date

Additional Testcases

• The safe bet: One Piece
• Episode 0: Saenai Heroine no Sodatekata ♭
• Unicode: Saenai Heroine no Sodatekata ♭
• Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

[justchokingaround]

i also refactored the args to be in alphabetical order

[justchokingaround]

TODO:

• [x] : fix shellscheck duh
• [ ] : update the help menu, man page and readme
• [x] : have chafa as fallback option and as default for windows
• [x] : implement rofi preview using the printf \x method
• [ ] : implement image caching, i would like to leave this to @Derisis13 if u don't mind

[Derisis13]

This is a lot of code (50+ lines, which is a 10% increase) already for a feature that's optional. @port19x what do you think?

[justchokingaround]

there will be more if we go for rofi implementation too

[port19x]

This is a lot of code (50+ lines, which is a 10% increase) already for a feature that's optional. @port19x what do you think?

I'm conflicted. 50 loc is a lot indeed, but perhaps warranted for a large feature like thumbnails. The question would then be if we accept a considerable bloating of our codebase for this feature.

Considering this doesn't include the rofi implementation I'd say it's not worth it. iirc jerry has thumbnail support, and that script is >1k loc (likely for other reasons too).

[port19x]

> i also refactored the args to be in alphabetical order

This makes it slightly confusing to review and assess the actualy scope increase caused by the feautre in isolation. Is it possible to extract the reordering into a separate refactor PR?

Not worth the hassle, since it's a naturally self-contained section of code it's not that bad

[justchokingaround]

this is what the implementation looks like. no external dependencies are required, except a minimum version of 0.44.0 for fzf

[port19x]

Please elaborate on the case for image caching

[port19x]

I think I get it. Say I want to watch all the differently named seasons of an anime, or all the one from franchise. Or maybe I want to watch the movies of a large anime. Then I'll search the same common term over and over again, thus there is benefit to caching.

[port19x]

Let's be real, this will never get done and that's not even much of an issue. I'm closing this ancient PR

[justchokingaround]

true lol