pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.9k stars 541 forks source link

feat: add --speed flag #1212

Closed Adamekka closed 1 year ago

Adamekka commented 1 year ago

Pull Request Template

Type of change

Description

works only on mpv, flatpak_mpv, iina, vlc

Checklist

Additional Testcases

port19x commented 1 year ago

This should be set in the configuration files of the video players instead

justchokingaround commented 1 year ago

actually the preferrable way would be to set ANI_CLI_PLAYER="mpv --speed=150" or whatever, in ur shell *rc

71zenith commented 1 year ago

that would not work since we put the whole command through dep_ch . it will complain that mpv --speed=150 is not in $PATH we can make the dep_ch function only check for the command up until space tho

71zenith commented 1 year ago

something like ${dep%% *}

justchokingaround commented 1 year ago

ye we should, can u push that to my pr branch?

71zenith commented 1 year ago

sure just a sec