pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.44k stars 530 forks source link

Partitioned the main file for enhanced readability and editability #1214

Closed muhiris closed 10 months ago

muhiris commented 10 months ago

Partitioned the main file for enhanced readability and editability without altering any code.

Pull Request Template

Type of change

Description

This pull request partitions the main file of ani-cli for enhanced readability and editability without altering the code.

Checklist

Additional Testcases

port19x commented 10 months ago

Bad Idea

We actually had a modular ani-cli for exactly one release in v3.2

It's a nightmare for packaging and really serves noone. I also disagree with the readability narrative. In one file you can just use the scroll wheel and don't have to change files. Also folding, section comments and occasional blank lines should help.

image

Derisis13 commented 10 months ago

Well in general people don't like putting anything but the executables in their path, so you need to put them in some kind of share, and we didn't know realpath existed and tried to do it with dirname... And moving some files here and others there exceeded some of our users abilities...

justchokingaround commented 10 months ago

lol