Closed HaxSam closed 10 months ago
balls
Since this is supposed to be a dev shell, good extra dependencies to include would be shfmt
and shellcheck
, as those are part of the CI pipeline as well
If those are included I may use this myself, as shellcheck has way too many deps
No problem, I can include that
also include the command to run the nix shell in question pls
also include the command to run the nix shell in question pls
Where should I include it? It's already as comment in the shell.nix
oh, my bad didn't see. ignore my comment
also include the command to run the nix shell in question pls
Where should I include it? It's already as comment in the
shell.nix
This would fit well towards the bottom of contributing.md
Like under a ## Development with nix
you could outline the usage and link to an entrypoint to external docs.
I find that preferable to comments within the file itself
Does this mean we're merging packaging scripts?
Does this mean we're merging packaging scripts?
No, nix is a heavily overloaded tool. What we're merging is a dev-environment wrapper.
Alternatives would include devcontainer
and vanilla Docker
A dev-environment wrapper? So essentially a fakeroot environment if someone wants to work on the project but not install the dependencies?
A dev-environment wrapper? So essentially a fakeroot environment if someone wants to work on the project but not install the dependencies?
yes, pretty much
Is all good now @port19x?
Pull Request Template
Type of change
Description
Added nix dev shell env. To use it go in the repo and use
nix-shell
in the dev shell you have all bin that ani-cli uses. With arguments you can also add vlc, chromecast support and so on is commented in theshell.nix
fileChecklist
[ ] bumped version
-c
history and continue work-d
downloads work-s
syncplay works-q
quality works-v
vlc works-e
select episode works-S
select index works-r
range selection works--dub
and regular (sub) mode both work[ ] all providers return links (not necessarily on a single anime, use debug mode to confirm)
-h
help info is up to dateAdditional Testcases