pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.44k stars 530 forks source link

test: add nix dev shell env #1218

Closed HaxSam closed 10 months ago

HaxSam commented 10 months ago

Pull Request Template

Type of change

Description

Added nix dev shell env. To use it go in the repo and use nix-shell in the dev shell you have all bin that ani-cli uses. With arguments you can also add vlc, chromecast support and so on is commented in the shell.nix file

Checklist

Additional Testcases

justchokingaround commented 10 months ago

balls

port19x commented 10 months ago

Since this is supposed to be a dev shell, good extra dependencies to include would be shfmt and shellcheck, as those are part of the CI pipeline as well

port19x commented 10 months ago

If those are included I may use this myself, as shellcheck has way too many deps

HaxSam commented 10 months ago

No problem, I can include that

justchokingaround commented 10 months ago

also include the command to run the nix shell in question pls

HaxSam commented 10 months ago

also include the command to run the nix shell in question pls

Where should I include it? It's already as comment in the shell.nix

justchokingaround commented 10 months ago

oh, my bad didn't see. ignore my comment

port19x commented 10 months ago

also include the command to run the nix shell in question pls

Where should I include it? It's already as comment in the shell.nix

This would fit well towards the bottom of contributing.md

port19x commented 10 months ago

Like under a ## Development with nix you could outline the usage and link to an entrypoint to external docs. I find that preferable to comments within the file itself

Derisis13 commented 10 months ago

Does this mean we're merging packaging scripts?

port19x commented 10 months ago

Does this mean we're merging packaging scripts?

No, nix is a heavily overloaded tool. What we're merging is a dev-environment wrapper. Alternatives would include devcontainer and vanilla Docker

Derisis13 commented 10 months ago

A dev-environment wrapper? So essentially a fakeroot environment if someone wants to work on the project but not install the dependencies?

port19x commented 10 months ago

A dev-environment wrapper? So essentially a fakeroot environment if someone wants to work on the project but not install the dependencies?

yes, pretty much

HaxSam commented 10 months ago

Is all good now @port19x?