search

pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.44k stars 530 forks source link

bug: rofi multi select if run from interactive shell not working out of the box #1225

Closed AzureOrange404 closed 9 months ago

AzureOrange404 commented 9 months ago

Metadata (please complete the following information) Version: 4.6.1 OS: Arch Linux 6.5.6 Shell: dash Anime: any

Describe the bug If invoking ani-cli --rofi from an interactive shell, without any env variables set, I cannot select multiple episodes to watch.

Steps To Reproduce

  1. Run ani-cli --rofi from an interactive shell
  2. Search any anime
  3. Choose any anime
  4. No multi-select possible
  5. Check command using ps aux | grep rofi
  6. rofi gets a -m flag instead of -multi-select

Expected behavior Rofi gets a -multi-select flag and supports selecting multiple episodes if run from an interactive shell.

Additional context

Pull request for a simple fix is already made.

justchokingaround commented 9 months ago

9ab1c5a57c21d10c57dfac9da09b3401a46d2791