Closed AzureOrange404 closed 8 months ago
Someone will have to first take me through ani-cli
code, especially the episode range parsing thing.
@synacktraa also pls implement skipping for outro as well
Here you go. https://github.com/synacktraa/ani-skip/commit/657a1de142ed1f7f846b130540cbb4564f7c42fa @71zenith
I plan to merge and release sometime later today
Looks good and works on my end
Needs sign off from @Derisis13 due to requested changes
Imma test some stuff with windows and WSL.
Imma test some stuff with windows and WSL.
ani-skip is working in Wsl Try gitbash too if possible
I am on Manjaro, not sure if that affects but getting the following output for ani-skip and one piece, am I doing something wrong? I tried the same with this PR as well but didn't see any skip so tried to do this.
ani-skip "1P (1084 episodes)" 341
--script-opts= '--script=/home/user/.config/mpv/scripts/skip.lua'
I am on Manjaro, not sure if that affects but getting the following output for ani-skip and one piece, am I doing something wrong? I tried the same with this PR as well but didn't see any skip so tried to do this.
ani-skip "1P (1084 episodes)" 341 --script-opts= '--script=/home/user/.config/mpv/scripts/skip.lua'
update ani-skip once. sudo ani-skip -U
I am on Manjaro, not sure if that affects but getting the following output for ani-skip and one piece, am I doing something wrong? I tried the same with this PR as well but didn't see any skip so tried to do this.
ani-skip "1P (1084 episodes)" 341 --script-opts= '--script=/home/user/.config/mpv/scripts/skip.lua'
update ani-skip once.
sudo ani-skip -U
This actually doesn't solve the problem. tried using One Piece
instead of 1P (1084 episodes)
and got the script opts:
works nicely (would have preferred to run it in background) about the one piece thing. im afraid there is so much we can do about it. they likely do it to not get noticed by the big corp daddies.
This actually doesn't solve the problem. tried using
One Piece
instead of1P (1084 episodes)
and got the script opts:
If there was no error, it means there was an entry related to 1P
, it's just that parsing is not working well. I'll do something about it. If it was python, we could have used vectors or ngrams to get most relevant entry.
Imma test some stuff with windows and WSL.
ani-skip is working in Wsl Try gitbash too if possible
For any windows users that setup ani-cli with scoop, the likely best way is to use scoop to create a shim for ani-skip as well.
step 1
scoop install { "version": "1.0", "url": "https://raw.githubusercontent.com/synacktraa/ani-skip/master/ani-skip", "bin": "ani-skip" }
step 2 Place https://raw.githubusercontent.com/synacktraa/ani-skip/master/skip.lua Into the mpv scripts folder.
Scripts folder autoruns any lua files in it so we can ignore the "--script=$HOME/.config/mpv/scripts/skip.lua" component of the ani-skip output as mpv will ignore it (with an error message saying file not found).
Otherwise if you'd like to have the script elsewhere you can edit the ani-skip's 4th line from the scoop install to be a windows folder path instead.
Pull Request
Type of change
Description
I saw the issue #1223 and sympathized with the idea of skipping intros. So implemented the skipping function into ani-cli (it still needs ani-skip to be installed though.)
Skipping does not work for all anime I've tested, but does for some. If ani-skip fails, ani-cli just prints a message stating, that it failed and proceeds as normal.
Also it only works with mpv (due to how ani-skip works) and this is noted in the help function as well as the man page.
Checklist
[x] bumped version
-c
history and continue work-d
downloads work-s
syncplay works-q
quality works-v
vlc works-e
select episode works-S
select index works-r
range selection works--dub
and regular (sub) mode both work[x] all providers return links (not necessarily on a single anime, use debug mode to confirm)
-h
help info is up to dateAdditional Testcases