pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.9k stars 541 forks source link

feat: add mpvnet support #1235

Closed Z1xus closed 10 months ago

Z1xus commented 10 months ago

Type of change

Description

Added support for mpvnet as an alternative to mpv for Windows users.

322 mentioned adding mpvnet as a player option, the issue was closed as completed but mpvnet support has never been added. Since mpvnet is just a fork of mpv it should work exactly the same, I ran a few tests and it all worked for me. Open to suggestions for improvements.

Checklist

Additional Testcases

port19x commented 10 months ago

Hard sell, why should windows users use mpv.net over mpv or vlc?

Z1xus commented 10 months ago

I just find mpvnet more convenient. Perhaps I should add it like vlc only when using an argument?

port19x commented 10 months ago

I just find mpvnet more convenient. Perhaps I should add it like vlc only when using an argument?

That's why we have an environment variable for it. Try putting export ANI_CLI_PLAYER="mpvnet.exe" in the applicable shell config

Z1xus commented 10 months ago

Oh, that's cool, i haven't thought about doing that manually. Sorry for wasting your time, you can close the pr now.