search

pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.9k stars 541 forks source link

MPV not found - but installed #1236

Closed l0rdsami closed 8 months ago

l0rdsami commented 10 months ago

Metadata (please complete the following information) Version: 4.6.0 OS: Windows 10 Shell: Git bash in Terminal Preview Anime: /

Describe the bug When trying to start ani-cli it states, that mpv is missing, but which mpv.exe resolves. sh -x $(which ani-cli) naruto -N -e 1 &>ani-cli.log logs only the following line: sh: /c/Users/Samuel: No such file or directory This is probably due to my Username having a space in its name.

Steps To Reproduce

  1. Have a space in your username
  2. Run ani-cli
  3. Be confused
  4. run which mpv.exe
  5. See it resolve
  6. run sh -x $(which ani-cli) naruto -N -e 1 &>ani-cli.log
  7. See the error

Expected behavior Should be ok with Spaces in Username

Additional context

l0rdsami commented 10 months ago

After reinstalling everything globally i get the same error but different log: ani-cli.log

port19x commented 10 months ago

Quoting issue, what I'm surprised by is that it doesn't work without sh -x $(which ani-cli) either

port19x commented 10 months ago

What's the output of which mpv.exe btw? Installing mpv through scoop may help since that resolves to a spaceless path as per your attached log

l0rdsami commented 10 months ago 

which mpv.exe
/c/ProgramData/scoop/apps/mpv/current/mpv.exe```
l0rdsami commented 10 months ago

And mpv is installed through scoop :)

l0rdsami commented 10 months ago

it works outside of git cli, in the terminal preview (the normal command prompt in terminal preview)

71zenith commented 10 months ago

it works outside of git cli, in the terminal preview (the normal command prompt in terminal preview)

so ure trying to run ani-cli through git bash?

l0rdsami commented 10 months ago

i was, yes i was following the readme on that one

petmav commented 8 months ago

Had this problem. I fixed it by manually adding the mpv.exe PATH to my Environment Variables. Not sure why the scoop download didn't get recognised, but now it works!

Sarvasv-0 commented 8 months ago

Had this problem. I fixed it by manually adding the mpv.exe PATH to my Environment Variables. Not sure why the scoop download didn't get recognised, but now it works!

Scoop would have probably complained about the directory not being in PATH, if not the scoop devs should do smth to inform the user if the directory is not in PATH