pystardust / ani-cli

A cli tool to browse and play anime
GNU General Public License v3.0
7.44k stars 530 forks source link

Fix: #1254, switch to a flake based approach #1256

Closed YvesStraten closed 6 months ago

YvesStraten commented 6 months ago

Pull Request Template

Type of change

Description

This PR aims to fix #1254, allowing ani-cli to be used on Macos with Nix. This PR also switches the shell.nix to a flake.nix, allowing for the following advantages:

  1. Ani-cli can now be runned with just nix-run
  2. The repo can be added as an input to the flakes of other people
  3. Ani-cli is built locally trough nix-build, not relying on the nixpkgs derivation, but the local git repo.

However, it comes with a few caveats due to the fact that nix flakes do not allow for argument passing, e.g --argstr:

  1. syncplay and chromecast are installed by default now (adds 10mb to install)
  2. There are 2 packages now, one with vcl and one with mpv (Iina is enabled on both of em conditionally depending on platform)

Checklist

Additional Testcases

port19x commented 6 months ago

Wrong repo imo

https://github.com/NixOS/nixpkgs

YvesStraten commented 6 months ago

are you sure? In that case ill open up a PR there then